Hi Ricardo,
Thanks for your comments! Last night i already fixed some of these
issues when Ludo pointed them out.
On 2015-10-22 at 08:41, quoth Ricardo Wurmus:
> Please use ‘(file-name ...)’ here as the tarball is only named
> ‘v2.7.1.tar.gz’.
OK, good point. I admit that i wasn't sure about that (it was indeed in
the `guix lint` output), but i have now added that to both the dosbox
and cmus packages. I'll email the patches shortly (since i had already
pushed cmus after getting approval from Ludo — sorry for my overly hasty
actions then!).
> Putting the ‘#f’ on a separate line looks odd. Please put ‘#:tests? #f’
> on one line together with the margin comment.
Already done.
>> + ("pkg-config" ,pkg-config)
>
> This should be in native-inputs instead.
Already done.
>> + (description "Cmus is a small, fast and powerful console music player
>> for
>> +Unix-like operating systems.")
>
> “for Unix-like operating systems” seems redundant as Guix only works on
> GNU systems.
Already done.
Thank you again!
p.
