Hi, [email protected] (Ludovic Courtès) writes:
> Mathieu Lirzin <[email protected]> skribis: > >> From a43f69d7f57df7ca2fb156ab75a845a68cc43d02 Mon Sep 17 00:00:00 2001 >> From: Mathieu Lirzin <[email protected]> >> Date: Sat, 21 Nov 2015 01:07:03 +0100 >> Subject: [PATCH] gnu: parted: Update to 3.2. >> >> * gnu/packages/disk.scm (parted): Update to 3.2. >> [inputs]: Add lvm2 and remove check. Replace readline-6.2 with its >> latest version. >> [native-inputs]: Add perl and python for the tests. >> [arguments]: Use `modify-phases' and adapt to the new tests. >> [home-page]: Use https. > > Thanks for tackling this. I think the reason this wasn’t done before is > that there were various issues, notably: > > https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00001.html > https://lists.gnu.org/archive/html/bug-parted/2014-08/msg00002.html > > and then I dropped the ball. :-) It helps alot to have some background. Thanks for this pointers. >> + (substitute* "tests/t0251-gpt-unicode.sh" >> + (("C.UTF-8") "en_US.UTF-8")) ;not in Glibc locales > > Rather “en_US.utf8”, because “utf8” is the “normalized codeset”. Done. >> + (inputs `(("lvm2" ,lvm2) >> + ("readline" ,readline) >> + ("util-linux" ,util-linux))) > > I’d prefer to avoid this alignment style. No big deal though. Fixed. Your nitpicking is always appreciated! ;) I will avoid this in my future package definitions. > OK with the above change, thank you! Pushed in 1b933e62dcc8521e383a78e5d7952a194e47a4ec. Thanks, -- Mathieu Lirzin
