Ludovic Courtès (2015-12-18 01:23 +0300) wrote: > Hi Alex! > > Sorry for the late reply. I wanted to take the time to sit back, relax, > and enjoy the new stuff… and I haven’t been disappointed! :-)
Great, thanks for giving your time to this! > This is awesome. Some queries seem to take longer on Hydra than others > (for instance, getting the list of builds of a given jobset is slow, > whereas getting the list of latest builds, queued builds, etc. is pretty > fast.) Yes, I also noticed that processing complex queries takes longer time. Perhaps SQL queries that stand behind this Hydra API are not efficient, dunno :-) > Perhaps one small improvement would be to add links from Package Info > buffers to the corresponding Guix Hydra Build Info? Do you mean a button that will do the same as "B" key in "Package List"? Anyway, I think eventually I'll add more various buttons to "Package Info" buffers (like "Hydra Builds", "Build Log", "Size", "Graph"), and more keys to "Package List" buffers for the same things. > I haven’t looked at the code yet, but it’s your area of expertise and > I’m confident. :-) I skim over it when you think it’s ready; are there > parts you’d like to be reviewed more carefully? Well, I always feel uncomfortable with commit messages. But I think the main part that should be reviewed is documentation (in commit 731f5e4). As for the changes in code, they are huge (and I would say "unskimmable"), and I think no one will want to look at them :-) > Anyway, let me know what you think and how you’d like to proceed. OK, I have done some final changes and rebased the branch on master, so (from my point of view) it is ready for merging. Should I spam the list with these (37) patches? -- Alex
