On Thu, Feb 25, 2016 at 01:28:54PM -0800, Christopher Allan Webber wrote: > Leo Famulari writes: > > > On Thu, Feb 25, 2016 at 09:53:17AM -0800, Christopher Allan Webber wrote: > >> This looks ready to go, though it still lacks a changelog style commit > >> message, and it isn't formatted with git format-patch. > >> > >> I could commit it myself with that, but I don't know if that would be > >> acceptable? (And should I commit it under my name, or set the author > >> name to Danny? I would certainly want to attribute to Danny.) > > > > It's actually possible to put anything you want in the '--author' field > > when committing. There is also '--sign-off', which you can use to > > indicate your approval of the author's patch. These options also exist > > in some other git tools, notably `git am`. > > Ok, good call. I probably should have done --sign-off, which I forgot > to, but I did commit it under Danny and pushed it.
It's useful but not essential, especially since you can make it say anything you want. The only way to *really* know who wrote what is to sign everything cryptographically.
