Leo Famulari <[email protected]> writes: > On Tue, May 31, 2016 at 09:13:04PM +0200, Ricardo Wurmus wrote: >> Leo Famulari <[email protected]> writes: >> >> > Icedtea 1.13.11 was released, which fixes a number of security bugs: >> > >> > http://blog.fuseyism.com/index.php/2016/05/04/security-icedtea-1-13-11-for-openjdk-6-released/ >> > >> > I tried to build it with the attached patch, but it fails for me. I've >> > attached the tail of the build log. Any advice? >> >> The patch looks good to me. If I understand correctly this may be >> because we’re bootstrapping with GCJ, which implements Java 1.5. You >> can see in the log that “javac” runs with “-source 1.5 -target 5”, which >> means that it assumes that the code is written in compliance with Java >> 1.5. Maybe this file simply is not valid Java 1.5. >> >> According to http://stackoverflow.com/a/8697805/519736 “@Override” is >> interpreted more strictly in 1.5. I don’t know much about Java and I >> haven’t looked at the sources in question, but I guess there are >> “@Override” annotations above the five method declarations. We might be >> able to just remove them. >> >> I think this should be reported to Andrew; looks like a bug as >> bootstrapping with GCJ should work for OpenJDK 6. > > Done: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2990
Thank you. Since this has been fixed here http://icedtea.classpath.org/hg/icedtea6/rev/60be25a84f2d we should apply this change to the 1.13.11 sources. ~~ Ricardo
