On Sun, Aug 21, 2016 at 12:13:45PM -0400, Matthew Jordan wrote:
> Subject: [PATCH 2/2] gnu: Add feed2maildir
> 
> * gnu/packages/mail.scm (python-feed2maildir): New variable.

Thanks!

I have the same feedback for this package as I did for
python-feedparser. Additional comments below.

> +    (arguments
> +     `(#:tests? #f))

When skipping tests, we must leave a code comment explaining why. It can
be as simple as "No test suite" if that's the case.

> +    (license
> +     (non-copyleft 
> "https://github.com/sulami/feed2maildir/blob/master/LICENSE";))))

This is the ISC license.

Reply via email to