Christopher Allan Webber <cweb...@dustycloud.org> skribis:
> From c8b122d8c7cf7a574bbbac66963ac355c64effc5 Mon Sep 17 00:00:00 2001
> From: Stephen Webber <webber...@gmail.com>
> Date: Sun, 16 Oct 2016 15:04:35 -0500
> Subject: [PATCH] gnu: Add kobodeluxe.
> * gnu/packages/games.scm (kobodeluxe): New variable.
> * gnu/packages/patches/kobodeluxe_paths.patch: New file.
> * gnu/packages/patches/kobodeluxe-spelling.patch: New file.
> * gnu/packages/patches/kobodeluxe_enemies-pipe-decl.patch: New file.
> * gnu/packages/patches/kobodeluxe_const_charp_conversion.patch: New file.
> * gnu/packages/patches/kobodeluxe_manpage-minus-not-hyphen.patch: New file.
> * gnu/packages/patches/kobodeluxe-midicon-segmentation-fault.patch: New file.
> * gnu/packages/patches/kobodeluxe_graphics_window-signed-char.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
Overall looks good to me! I have minor/cosmetic suggestions, but
otherwise this is ready for commit IMO.
> + %D%/packages/patches/kobodeluxe_paths.patch
> + %D%/packages/patches/kobodeluxe-spelling.patch
> + %D%/packages/patches/kobodeluxe_enemies-pipe-decl.patch
> + %D%/packages/patches/kobodeluxe_const_charp_conversion.patch
> + %D%/packages/patches/kobodeluxe_manpage-minus-not-hyphen.patch
> + %D%/packages/patches/kobodeluxe-midicon-segmentation-fault.patch
> + %D%/packages/patches/kobodeluxe_graphics_window-signed-char.patch
Maybe use only hyphens in file names for consistency.
> + (synopsis "Shooter with space station destruction")
> + (description
> + "Kobo Deluxe is an enhanced version of Akira Higuchi's XKobo for Un*x
> +systems with X11.")
Maybe s/XKobo.*/XKobo graphical game/.
That way ‘guix package -s game’ will return it. :-)
> --- /dev/null
> +++ b/gnu/packages/patches/kobodeluxe-spelling.patch
> @@ -0,0 +1,25 @@
> +Description: two spelling fixes
> +Author: Damyan Ivanov <d...@debian.org>
Maybe this patch can be omitted; hopefully it’ll be fixed in the next
> +++ b/gnu/packages/patches/kobodeluxe_paths.patch
> @@ -0,0 +1,40 @@
> +# Disable reading of configs, graphics, and data from the current directory.
> +# So it's safe to run kobodeluxe from anywhere w/o worry about an attacker
> +# feeding it bad data.
Could you indicate the origin or status of this patch?
Chris: feel free to push an updated version!
Stephen, you picked a tricky package as your first patch but it’s
perfect! I’m sure you had a good mentor too. ;-)