Tomáš Čech <sleep_wal...@gnu.org> skribis:
> * gnu/services/networking.scm (wpa-supplicant-service): New procedure.
> (wpa-supplicant-service-type): New variable.
> (wpa-supplicant-shepherd-service): New procedure.
> * doc/guix.texi (Networking Services): Document it.
Could you remove the ‘wpa-supplicant-service’ procedure and simply
expose and document ‘wpa-supplicant-service-type’? So users would
write:
(service wpa-supplicant-service-type wpa-supplicant)
instead of:
(wpa-supplicant-service)
I’m trying to incrementally get us to do that for all services, because
I think it’s a bit clearer (one immediately sees what type of
configuration value is used.)
> +@cindex WPA Supplicant
> +@deffn {Scheme Procedure} wpa-supplicant-service @
> + [#:wpa-supplicant @var{wpa-supplicant}]
> +Return a service that runs @url{https://w1.fi/wpa_supplicant/,WPA
> +supplicant}, an authentication daemon required to authenticate against
> +encrypted WiFi or ethernet networks.
Could you also mention that wpa_supplicant is started to listen on a
D-Bus interface?
> + (requirement '(user-processes dbus-system loopback))
> + (start #~(make-forkexec-constructor
> + (list (string-append #$wpa-supplicant
> + "/sbin/wpa_supplicant")
> + "-u" "-B")))
I think it would be more reliable to use
“-P/var/run/wpa_supplicant.pid”, and thus
#:pid-file "/var/run/wpa_supplicant.pid"
OK with changes along these lines, thanks!
Ludo’.
