Hartmut Goebel <[email protected]> skribis: > * guix/scripts/gc.scm (show-help, %options): Add option -k/--keep-going. > (guix-gc): Pass value off option --keep-going on to delete-paths. > * guix/store.scm (%protocol-version): Increment to 17. > (delete-paths) New key-word parameter `keep-going?`, pass it on to > run-rc. > (run-gc): New key-word parameter `keep-going?`, send value of > keep-going? to the daemon. > * nix/libstore/store-api.hh (GCOptions): Add boolean keepGoing. > * nix/libstore/worker-protocol.hh (PROTOCOL_VERSION) Increment to 17. > * nix/nix-daemon/nix-daemon.cc (performOp)[wopCollectGarbage] Read > keepGoing. > * nix/libstore/gc.cc (LocalStore::collectGarbage) If keepGoing is true > print an error message instead of throwing an error. > * doc/guix.texi (Invoking guix gc): Document option --keep-going.
That’s a good idea! One comment to complement Eric’s review: could you add a test, in tests/store.scm, along the lines of the "dead path can be explicitly collected"? Ideally one test with keep-going, and one without. (See <https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html>.) Thank you! Ludo’.
