On Fri, 18 Nov 2016 16:04:30 -0500 Leo Famulari <[email protected]> wrote:
> On Wed, Nov 16, 2016 at 09:29:18PM -0600, Eric Bavier wrote: > > Hello Guix, > > > > We've had at least one person on IRC confirm that this firmware package > > worked for them, allowing them to use their wireless hardware. > > > > Would it be appropriate to add this to %base-firmware? The output is > > rather small. > > How small? 36K > Since they seem to work, I'd say they should be added. > > > From c397f73d69326db24c211e4e2bda46e647d0e751 Mon Sep 17 00:00:00 2001 > > From: Eric Bavier <[email protected]> > > Date: Thu, 12 May 2016 13:57:01 -0500 > > Subject: [PATCH] gnu: Add openfwwf-firmware. > > > > * gnu/packages/firmware.scm (b43-tools, openfwwf-firmware): New > > variables. > > > +(define-public b43-tools > > + (let ((commit "8dce53297966b31b6c70a7a03c2433978dd9f288") > > + (rev "1")) > > How do we choose a commit? This was the latest commit at the time of packaging. There have been new commits since, but they affect only the debugging tools, which we do not build here. > > + (package > > + (name "b43-tools") > > + (version (string-append "20140625-" rev "." (string-take commit 7))) > > > > Is the timestamp some kind of upstream version string? If not, and there > is no upstream version naming, we should use 0.0.0, right? This package contains a collections of tools, only one of which declares any sort of version (fwcutter). I had gathered that the date-string approach was acceptable for VCS checkouts when versions are otherwise not available. We have 34 other packages whose version begin with such a date-string (e.g. guile-minikanren, scmutils, guile-for-guile-emacs, guile-emacs, woff2, font-google-noto, ...). > > + #:phases > > + (let ((subdirs '("assembler" "disassembler"))) ;TODO: fwcutter > > Can you expand the TODO comment? I may just remove it. If someone needs the other tools, they should know what to do. `~Eric
