Kei Kebreau <k...@openmailbox.org> writes: > I think the patch works fine, but I'd love to hear comments about its > clarity.
Hi! Thanks for this patch. The source includes a pre-compiled 32-bit
version in "linux_32bit". Can you remove that with a source snippet?
> From d1031c30c57eb6f292a91963801f87b419d8bee2 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <k...@openmailbox.org>
> Date: Mon, 21 Nov 2016 17:35:00 -0500
> Subject: [PATCH] gnu: Add espeak.
>
> * gnu/packages/audio.scm (espeak): New variable.
> ---
> gnu/packages/audio.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 77d3b53..8aba416 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -343,6 +343,52 @@ tools (analyzer, mono/stereo tools, crossovers).")
> ;; The plugins are released under LGPLv2.1+
> (license (list license:lgpl2.1+ license:gpl2+))))
>
> +(define-public espeak
> + (package
> + (name "espeak")
> + (version "1.48.04")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/espeak/espeak-1.48/"
Two comments: The URL should be
"mirror://sourceforge/espeak/espeak/espeak-1.48" (note the extra
"espeak").
In addition, you can use the "version-major+minor" procedure instead of
hard coding "1.48" here.
Other than that this LGTM!
> + "espeak-" version "-source.zip"))
> + (sha256
> + (base32
> + "0n86gwh9pw0jqqpdz7mxggllfr8k0r7pc67ayy7w5z6z79kig6mz"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs
> "out"))
> + (string-append "DATADIR="
> + (assoc-ref %outputs "out")
> + "/share/espeak-data")
> + (string-append "LDFLAGS=-Wl,-rpath="
> + (assoc-ref %outputs "out")
> + "/lib")
> + "AUDIO=pulseaudio")
> + #:tests? #f ; no check target
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda _
> + (chdir "src")
> + ;; We use version 19 of the PortAudio library, so we must copy
> the
> + ;; corresponding file to be sure that espeak compiles correctly.
> + (copy-file "portaudio19.h" "portaudio.h")
> + (substitute* "Makefile"
> + (("/bin/ln") "ln"))
> + #t)))))
> + (inputs
> + `(("portaudio" ,portaudio)
> + ("pulseaudio" ,pulseaudio)))
> + (native-inputs `(("unzip" ,unzip)))
> + (home-page "http://espeak.sourceforge.net/";)
> + (synopsis "Software speech synthesizer")
> + (description "eSpeak is a software speech synthesizer for English and
> +other languages. eSpeak uses a \"formant synthesis\" method. This allows
> many
> +languages to be provided in a small size. The speech is clear, and can be
> used
> +at high speeds, but is not as natural or smooth as larger synthesizers which
> are
> +based on human speech recordings.")
> + (license license:gpl3+)))
> +
> (define-public infamous-plugins
> (package
> (name "infamous-plugins")
> --
> 2.10.2
>
signature.asc
Description: PGP signature
