Marius Bakke <[email protected]> skribis:
> * gnu/build/activation.scm (make-file-writable): Move this to ...
> * guix/build/utils.scm (make-file-writable): ... here. Export it.
> * guix/build/gnu-build-system.scm (strip): Use it.
[...]
> --- a/guix/build/gnu-build-system.scm
> +++ b/guix/build/gnu-build-system.scm
> @@ -393,8 +393,10 @@ makefiles."
> (or (elf-file? file) (ar-file? file))
> (or (not debug-output)
> (make-debug-file file))
> - ;; Ensure libraries are writable.
> - (chmod file #o755)
> +
> + ;; Ensure the file is writable.
> + (make-file-writable file)
The return value of ‘chmod’ and ‘make-file-writable’ is unspecified, so
you need to write:
(begin (make-file-writable file) #t)
> +(define (make-file-writable file)
> + "Make FILE writable for its owner.."
^
Take it as an opportunity to remove this extra period. :-)
Otherwise LGTM.
Ludo’.
