Danny Milosavljevic <dan...@scratchpost.org> writes: > * gnu/packages/databases.scm (python-pyodbc-c, python2-pyodbc-c): > New variables. > --- > gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index e8be17980..fc576888d 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -1312,3 +1312,29 @@ development.") > ;; test/crypto.test are licensed under a 3-clause BSD license. All other > ;; source files are in the public domain. > (license (list license:public-domain license:bsd-3)))) > + > +(define-public python-pyodbc-c > + (package > + (name "python-pyodbc-c") > + (version "3.1.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://gitlab.com/daym/pyodbc-c/repository/" > + "archive.tar.gz?ref=v" version)) > + (sha256 > + (base32 "0nl11n3mgrcfnhimjqgv48rxqnb21l5m6s7p8ps2fa4nn4z6rzy0"))
I would put this as (sha256 (base32 "")) but I guess this works too as long as lint is happy. > + (file-name (string-append name "-" version ".tar.gz")))) > + (build-system python-build-system) > + (inputs > + `(("unixodbc" ,unixodbc))) > + (arguments > + `(#:tests? #f ; no tests exist > + )) > + (home-page "https://github.com/mkleehammer/pyodbc") This is pulled from gitlab and the homepage is on gitlab? I think it's better to use the gitlab repository as home-page then, or what's the reason? > + (synopsis "Python ODBC Library") > + (description "This package provides a Python DB-API driver for ODBC.") If I remember correctly, we should avoid starting synopsis and description with words like "This". What about: (description "@code{python-pyodbc-c} provides …" > + (license (license:x11-style "file://LICENSE.TXT")))) > + > +(define-public python2-pyodbc-c > + (package-with-python2 python-pyodbc-c)) > Besides those small comments it looks good to me! -- ♥Ⓐ ng0 -- https://www.inventati.org/patternsinthechaos/