-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Apologies for the delay - in a shocking twist, it turns out professors insisting on only one exit from functions had a point, and trying to fully understand what optimisePath_, with its 14 exits and a goto, does, was a challenge. I think I handle most of the main error cases (EEXIST, ENOSPC, EMLINK) sort of okay now (the "shrug and ignore" sort of exceptions are now caught, the rest are still propagated). I've also created guix/store/deduplication.scm, and moved the relevant stuff there. The tests pass to the same degree as before (2 failing, but neither of them are register-path).
Here is my test-suite.log:
test-suite.log
Description: Binary data
When I create a new module that directly incorporates code written by others (as in the case of moving reset-timestamps to (guix store deduplication)), should I add anything to the copyright notice at the top? Would that involve looking through the commit history to find exactly who wrote that? I read HACKING - does the part about waiting two weeks for feedback on guix-patches before committing still apply to branches? I've now updated my savannah account with a key, used to sign this. -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEdNapMPRLm4SepVYGwWaqSV9/GJwFAlk+InUACgkQwWaqSV9/ GJxpRAf+KWd4IQGdcGi4ret3GCfGJcfsmmZiSni8enzo4EdKmxT4MOf/FYwnrOHF ZB33YSc2mlhxPKs1y2soWHsPYyhODVL2sy3jQ4CKSpINZNqb0iHts8zfDSDRQoKi krOzPZTB7o1eOHYDS9xXnwqoNdGRzwG1KrdQZYCAIg6/UdkFaWevSn+Vo1LgzRp+ IFUxrLj92JxBraiyhQV4Uf7hALhA3WWKOym/9K5WN/NO8x4Somv4nIdrMFS21euq qQbPzZ+5gb0m8k0smH6JC3E7DkPXL0UYTdbdsr4aGxIIFvwy6qLmDyBKZR7ieDjM x2fTJp20v+28BV0Gzbtk4LnK1v59zA== =1ttQ -----END PGP SIGNATURE-----
