On February 5, 2018 6:11:25 PM EST, Leo Famulari <[email protected]> wrote: >On Mon, Feb 05, 2018 at 05:39:50PM -0500, dpg wrote: >> Sending a new patch, this will apply cleaner and has an actually good >commit >> message :-) > >Thanks! But it still didn't apply :) > >> From 300c37a8d9818cfc1a6315d2113cf58b110e1664 Mon Sep 17 00:00:00 >2001 >> From: DoublePlusGood <[email protected]> >> Date: Mon, 5 Feb 2018 17:26:34 -0500 >> Subject: [PATCH] gnu: python: Add python2-gyp >> >> * gnu/packages/python.scm: Added python2-gyp library. > >> + ;; Google does not release versions, >> + ;; based on second most recent commit date. >> + (version "2017-10-11") > >As described in the manual section Version Numbers, we handle >versioning >of version control checkouts in a specific way: > >https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers > >This allows us to ensure that the versions always increase and can be >used to refer back to the upstream version control repository. At least >in Git, dates are not meaningful. They can be set to anything with the >--date parameter. > >We also have the special helper functions git-version and git-file-name >to make it easy to use the standard versioning scheme. > >I standardized the version and source file-name as in the attached >diff, >standardized the commit message, updated the copyright date, and pushed >the result as commit 956ba99cb799889e0a0bc0f657f4e31b4f830775.
Wow, thank you! I have a couple other patches on my personal branch and I'll be sure to apply similar changes. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
