Hi Sahithi, >> Another note about style: I think it would be better to use >> “alist->hash-table” instead of “make-hash-table” followed by repeated >> modifications to the hash table with “hashq-set!”. We prefer to avoid >> mutation of values when possible. > > I have made all necessary modifications. Can please review it once.
Thanks, this looks fine. You don’t need (srfi srfi-13) for “string-join”. >> Regarding copyright headers: please make sure to also add a copyright >> line for yourself and a copyright line from the file of guile-colorize >> to “(guix ui)”. >> >> When you’re done with these changes, please make a local commit and send >> the output of “git format-patch -1”. > > > I will proceed further once it is reviewed. :) Please proceed with the patch. I’d like us to make progress a little more quickly going forward. Thanks! -- Ricardo
