Hello! Caleb Ristvedt <[email protected]> skribis:
> Ludovic Courtès <[email protected]> writes: > >> Could you try and rebase ‘guile-daemon’ on top of these modules? I’m >> happy to answer any questions you may have regarding modifications that >> I made. > > I'm not sure what is meant by "on top of these modules". If I understand > correctly, the problem is that while technically guile-daemon is rebased > on master (ran the git commands, they finished succesfully, etc), it's > not really as if the changes were written "with master in mind", so to > speak. That is, we end up with weird-looking stuff like adding > register-path to (guix store) *after* we already have register-items, > just to remove it a few commits later, adding and then removing (guix > sql), etc. And while technically it ends up "in the right place" now, a > coherent commit history is always good. > > Is that about right? Yes, that’s what I had in mind. :-) So everything that touches the database should be made via the (guix store database) module that’s currently in ‘master’. But I’ve seen you’ve already made changes since then so maybe we’re all good? Anyway, do ping me when you have reasonably small chunks of code that you think should be applied to ‘master’! > I'd hate for all those hours poring over C++ to go wasted! Heheh. :-) Ludo’.
