Efraim Flashner <efr...@flashner.co.il> writes: > On Thu, Mar 28, 2019 at 06:14:48PM +0000, Christopher Baines wrote: >> >> guix-comm...@gnu.org writes: >> >> > - (or (zero? >> > - (apply system* "gem" "install" gem-file >> > - "--verbose" >> > - "--local" "--ignore-dependencies" "--vendor" >> > - ;; Executables should go into /bin, not >> > - ;; /lib/ruby/gems. >> > - "--bindir" (string-append out "/bin") >> > - gem-flags)) >> > + (or (apply invoke "gem" "install" gem-file >> > + "--verbose" >> > + "--local" "--ignore-dependencies" "--vendor" >> > + ;; Executables should go into /bin, not >> > + ;; /lib/ruby/gems. >> > + "--bindir" (string-append out "/bin") >> > + gem-flags) >> > (begin >> > (let ((failed-output-dir (string-append (getcwd) "/out"))) >> > (mkdir failed-output-dir) >> >> Hey Efraim, >> >> Given that invoke raises an exception, I doubt the custom error handling >> code here will ever be executed. >> >> I guess you could change it to catch the exception, but using system* >> and looking at the exit code seems pretty reasonable to me. What do you >> think? >> >> Chris > > I was looking to get rid of some more of the 'zero? system*' code but I > think you're right. I'll go ahead and revert it and add a note about why > it should be left as-is.
Great, thanks Efraim :)
signature.asc
Description: PGP signature
