Robert Vollmert <[email protected]> writes:
> [ missed the list cc previously ] > >> On 14. Jun 2019, at 21:59, Ricardo Wurmus <[email protected]> wrote: >>> * I can run etc/indent-code.el by hand from the guix source >>> repo, but it would be much nicer to have it available as a >>> regular executable. >> >> I would not package it. Isn’t it already usable as an executable? It >> is a regular script after all. > > Well here it starts with #!/usr/bin/emacs --script. And guix environment guix > doesn’t provide emacs. It felt like the right way around that would be to > package it, but perhaps adding emacs to the environment and change > the shebang to /usr/bin/env emacs would be a good change then? The shebang is a placeholder. When you run the configure script the placeholder is replaced with whatever “emacs” was detected. >> Some existing code, however, may predate our indentation refinements, >> and yet other parts may have been overlooked. When we touch those >> sections anyway we may also adjust the indentation, but making purely >> cosmetic commits is discouraged. > > I’m curious, why is that discouraged? In my experience for this kind of > formatting issue, the best approach is to get it over with once and for all > and enforce the standards from that point. It makes for bad git logs and limits the usefulness of “git blame”. -- Ricardo
