On 14. Jul 2019, at 20:19, Julien Lepiller <[email protected]> wrote: > > Le Sun, 14 Jul 2019 15:40:43 +0200, > Ludovic Courtès <[email protected]> a écrit : >> The effect of this change is to import the (json parser) from the host >> side into the build side. >> >> As a result, if I have installed Guile-JSON 1.2 and you have >> Guile-JSON 3.1, we’ll end up building different derivations (and one >> of them won’t build :-)). >> >> The solution here would be to do the equivalent of ‘with-extensions’ >> for gexps. >> >> However, given that that’s annoying to do without gexps, and given >> that the plan is to move build systems to gexps Real Soon, I’d be in >> favor of simply reverting this commit and using the custom JSON >> parser. We can add a TODO/FIXME explaining that we’ll replace it >> with Guile-JSON as soon as build systems are rewritten to use gexps. >> >> How does that sound? >> >> Apologies if I overlooked it in your initial patch submission! >> >> Thank you, >> Ludo’. > > OK, sorry for pushing this patch then... I've reverted it in > a4bb18921099b2ec8c1699e08a73ca0fa78d0486. Thanks for the explanation!
It’s a bit my fault, for remarking on the fact that the cargo build system does use guile-json. I suppose that’s not worth fixing either at this point? Cheers Robert
