Ludovic Courtès writes:
>> vm: Make the device node procedure a parameter.
>> #:bootcfg-drv grub.cfg
>> #:bootloader grub-bootloader
>> #:register-closures? #f
>> + #:device-nodes 'hurd
>> #:extra-directives hurd-directives))
>
> On ‘core-updates’, there’s already #:device-nodes 'hurd, though not on
> the same line.
>
> I think we can drop this patch, no?
Oops, sure; dropped.
We may even want to move this (and "friends") into the qemu-image
declaration itself; in a much later patch on wip-hurd-vm I have
(define* qemu-image #:key
[...]
- (file-system-type "ext4")
- (file-system-options '())
- (device-nodes 'linux)
+ (file-system-type (if (hurd-target?) "ext2" "ext4"))
+ (file-system-options
+ (if (hurd-target?) '("-o" "hurd") '()))
+ (device-nodes (if (hurd-target?) 'hurd 'linux))
Having linux-specific defaults in a generic function is kind of awkward;
we would need to change all callers, or ...
Well, that's for later to be sure!
Greetings,
janeke
--
Jan Nieuwenhuizen <[email protected]> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
