On Tue, 16 Mar 2021 at 19:51, Léo Le Bouter <[email protected]> wrote: > On Tue, 2021-03-16 at 19:46 +0100, zimoun wrote:
> > Well, it seems better to send such changes to guix-patches, waiting > > 15 > > days, and then if no comment, push. It is what the manual describes: > > > > Non-trivial patches should always be posted to > > [email protected] (trivial patches include fixing typos, > > etc.). […] > > > > For patches that just add a new package, and a simple one, > > it’s OK to > > commit, if you’re confident […]. Likewise for package > > upgrades, except > > upgrades that trigger a lot of rebuilds […]. > > > > […] > > > > […] If you didn’t receive any reply after two weeks, and if > > you’re confident, it’s OK to commit. > > > > <http://guix.gnu.org/manual/devel/en/guix.html#Commit-Access> > > > > And from my understanding, it is a non-trivial patch which triggers a > > lot of rebuilds. Double reasons. ;-) > > It's not just like any other patch, it's a security patch, so **15** > days.. "To me, security is important. But it's no less important than everything *else* that is also important!" And nothing blocks you to have the patch in your tree in these (max) 15 days review time.
