Hi, On Thu, 14 Sept 2023 at 18:51, Ludovic Courtès <l...@gnu.org> wrote:
> For the record, that’s a 6% increase: > > --8<---------------cut here---------------start------------->8--- > $ guix size guix | tail -1 > total: 633.0 MiB > $ guix size guix git-minimal | tail -1 > total: 675.7 MiB > --8<---------------cut here---------------end--------------->8--- > > (Of course it all adds up; I’m not saying we can dismiss it.) > > In the context of <https://issues.guix.gnu.org/65866> plus the lack of > GC in libgit2 discussed in <https://issues.guix.gnu.org/65720>, my > inclination is to include that hard dependency on Git. And considering bug#65924 [1], it is not 6% but more. Because currently git-minimal is broken and coreutils and potentially util-linux would also be part of the closure. --8<---------------cut here---------------start------------->8--- $ guix size guix | tail -1 total: 633.0 MiB $ guix size guix git-minimal coreutils | tail -1 total: 692.7 MiB $ guix size guix git-minimal coreutils util-linux | tail -1 total: 706.6 MiB --8<---------------cut here---------------end--------------->8--- Therefore. it is 9.4% or worse 11.6%. 1: bug#65924: git searches coreutils and util-linux commands in PATH Maxim Cournoyer <maxim.courno...@gmail.com> Wed, 13 Sep 2023 14:00:09 -0400 id:87fs3iuf6e....@gmail.com https://yhetil.org/guix/87fs3iuf6e....@gmail.com https://issues.guix.gnu.org/msgid/87fs3iuf6e....@gmail.com > That’s not a happy choice for me, but it has the advantage of solving > two immediate problems. Three. :-) Once git-minimal and plumbing Git commands around, some slow procedures using libgit2 will be replaced by faster ones. And I also have in mind some Git repository normalization that differs from SWH; having plain Git commands would also easy that part. Just to point that the introduction of git-minimal as hard dependency of Guix means that libgit2 will be slowly removed from the picture, IMHO. Cheers, simon
