> I have recently been surprised by committers approving pull requests,
> wondering why they did not instead push them themselves. It might make
> sense when reacting to other committers (we never discussed whether it
> would be more polite to let committers push their own commits, or okay
> to push on their behalf), but it feels counterproductive with
> non-committers.

So, ... what is the conclusion regarding approvals ?

Not particularly in a hurry myself, but I just noticed I have 10 of them
in some kind of limbo, waiting for something to happen.

Do we have a policy about this ? I feel like approved changes get
committers away from them, as there is no need for a review, already
done.

C.

Attachment: signature.asc
Description: PGP signature

Reply via email to