Hello Yarl,

Yarl <[email protected]> skribis:

> Is 'derivation paths' a subset of 'direct store paths' or I am wrong?
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/guix/store.scm b/guix/store.scm
> index 4fd42cc658..1cf3c241bf 100644
> --- a/guix/store.scm
> +++ b/guix/store.scm
> @@ -2040,7 +2040,7 @@ (define (direct-store-path path)
>  
>  (define (derivation-path? path)
>    "Return #t if PATH is a derivation path."
> -  (and (store-path? path) (string-suffix? ".drv" path)))
> +  (and (direct-store-path? path) (string-suffix? ".drv" path)))
>  
>  (define (store-path-base path)
>    "Return the base path of a path in the store."
> --8<---------------cut here---------------end--------------->8---

This patch looks correct to me.

Could you send it as a pull request, together with a test in
‘tests/store.scm’?

Thanks for catching this!

Ludo’.

Reply via email to