Hi Hilton, On 2026-10-16 at 13:17+08:00, Hilton Chain wrote: > > f013a062f636b0c8f4b30e7aca305c0621070cf7 gnu: home: dotfiles: Exclude > > directories. > > A different question: I'm not sure why I'm listed in ‘Reviewed-by’. > I commented on the pull request but didn't approve it > or explicitly said to add my name. In fact I neither knew > its exact implementation nor had actually tested it.
I'm sorry, I think I saw the following and misread sarg as hako somehow. > hako added the team-core-packages, team-home labels last year > > sarg approved these changes last year > > hako commented last year The commit was picked up for misc-world-rebuild in May (then split out to another world-rebuild iteration for debugging the former so it's only landed on master now) so it was more of a guess of what happened. On 2026-10-16 at 13:17+08:00, Hilton Chain wrote: > What's the common practice on the trailers? My personal practice > is to link to the original information and add names > only when explicitly asked. I don't think there's been any formalization regarding the practice (and there probably should). What I do is list reviewers by those either approving or having applied suggestions as Reviewed-by. I imagine that would help collect a useful list of people for future contributors to reach out for help when hacking on the same packages or procedures. Kind regards, Phong
