Hugo Buddelmeijer <[email protected]> writes:
> It printed the correct dependency; the detection was a false positive,
> since that specific dependency was not going to be removed.
>
> This is the output of 0.0.2, when ran on
> 49cdea04fcc93c7023e0a6b96384b1d1c0f34c86, the commit of #12231:
>
> • #12073 Post merge go-team cleanups 2026/10. 🕓 Scheduled in 13 days
> ...
> - go-github-com-rogpeppe-go-internal-1.14
> ...
>
> Affected packages (16):
> • git-spice
> - go-github-com-rogpeppe-go-internal-1.14
> • shfmt
> - go-github-com-rogpeppe-go-internal-1.14
> ...
>
> None of the packages I checked are actually affected.
We must not be reading the same things, because those packages *are*
affected. Here you have a excerpt of their definition:
--8<---------------cut here---------------start------------->8---
(define-public git-spice
(package
(name "git-spice")
(version "0.23.0")
;; ...
(native-inputs
(list ;; ...
go-github-com-rogpeppe-go-internal-1.14
;; ...
))
;; ...
))
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
(define-public shfmt
(package
(name "shfmt")
(version "3.12.0")
;; ...
(native-inputs
(list ;; ...
go-github-com-rogpeppe-go-internal-1.14
;; ...
))
;; ...
))
--8<---------------cut here---------------end--------------->8---
> It correctly detects that go-github-com-rogpeppe-go-internal-1.14 is to
> be removed, but subsequently list a bunch of packages that depend on
> go-github-com-rogpeppe-go-internal, which is version 1.16.
For your current channels (and mines too), the version of
`go-github-com-rogpeppe-go-internal` that `git-spice` and `shfmt` depend
on is 1.14. The tool correctly detects that they will be affected by
the removal of the symbol. Guessing the order in which committers may
merge different PRs and how they compose, it's outside of the scope of
this extensions. That's to say, if the PR removes a symbol that will
affect some packages, it will be flagged. If a separate PR where to
address it (eg: updating the inputs) to a newer version, this extension
won't handle it.
Therefore, in you example, PR #12073 removes the
`go-github-com-rogpeppe-go-internal-1.14` symbol; in your current
channels, `git-spice` and `shfmt`, depend on that symbol.
> I'm curious how you actually implemented things, because my (very brief)
> attempts were blocked by Anubis; it being a scraper after all.
It's not scraping. It's using the Guile-Forgejo[1] library to request
the PRs having a deprecation label. It's a single request[2] not a
continuous hammering of the API, so I'm hopping this Anubis problem
you've got is a temporary issue.
[1] https://codeberg.org/guile-forgejo/guile-forgejo
[2]
https://codeberg.org/guix-extensions/removal-reporter/src/main/guix/extensions/removals.scm#L249
Best regards,
Sergio