Hi, On 2026-11-12 at 16:04+00:00, Untrusem wrote: > On November 7, 2026 8:44:57 PM UTC, Ludovic Courtès wrote: > > when I do ‘git merge-pull-request 123’, it automatically adds > >“Merges: #123” as a trailer on the last commit. > > Thanks this will come in handy for single pr merges. > But how will it handle the scenario I mentioned in my original mail?
Since I have to fix up the commit messages quite often (it'd be a nuisance to the authors to be bugged about nit picks IMHO), I always `git cherry-pick -se' to read the message and diff the final time, insert the Merges, Fixes (`oMerges: <Esc>p' in Vim) and Reviewed-by (name and mail address copied from `git log') trailers. As we cherry-pick and not actually merge, I think it's better for all applied patches to reference the PR. It's less convenient to jump around the log to find the original PR for the discussion. If we put the burden of these trailers on the authors, it would generate a lot of x-ref noises and increase the number of round trips. On 2026-11-12 at 12:56+01:00, Ludovic Courtès wrote: > Nguyễn Gia Phong <[email protected]> skribis: > > Can we standardize towards URLs, so they can be yanked > > into browser address bars? > > The rationale for not doing that is to have future-proof references: if > we move to a different host, “guix/guix#123” may still be valid whereas > the full URL would not. It's not exactly future proof, e.g. if we move to a patch tracker without the superfluous namespace. It's also weird on mirrors *with* the superfluous namespace, e.g. https://forgejo.example/foo/bar as it references https://forgejo.example/guix/guix/issues/123 which might not exist or be an entirely different thing. There's also no warranty that the next migration will duplicate the issue and patch tracking, as it did not happen to Debbugs data. Git is supposed to be decentralized, thus IMO it's not the greatest thing ever to have implicit reference to centralized third-parties. It's just not designed that way and fall apart in scenarios like described above. On 2026-11-12 at 12:56+01:00, Ludovic Courtès wrote: > Also, there are tools that make these things clickable hyperlinks: in > the Forgejo web interface, in Emacs, and probably others. This is like mentioning OCR on complaints about screenshots of text. Retyping the commit URL is slightly better with browser macros (as I can copy the hash, which is a word, via double click, unlike the number in the PR ref DSL), but Codeberg is slooow, and I don't use Emacs. I would not be this annoyed if Git CLI has a configuration to post-process the commit messages though, not to mention when I'm confirming the message after conflict resolution while rebasing topic branches. TBF it's not that big of a deal and I can live with the slightly worse UX if no one else face the same problem though. Kind regards, Phong
