Thanks. Done as of r662 On Mon, Jan 24, 2011 at 8:02 AM, ep <[email protected]> wrote:
> hi Fred, another question came up on LogRecord: for formatted message > you generate a stacktrace on the client everytime > com.allen_sauer.gwt.log.shared.LogRecord.getFormattedMessage() is > called, so that > > logRecord.getFormattedMessage() != logRecord.getFormattedMessage(); > > so actually, you "snapshot" the stacktrace on the client not during > creation of a LogRecord but rather upon getFormattedMessage() > invocation. Why not putting formatted message creation into the <init> > of LogRecord? All Loggers anyway call that method along when they do > their job, also currently getFormattedMessage() has O(n) ( n = number > of loggers ) whereas could have been running in constant time... > > Maybe I did not get it right, so if your idea really was to make a > stacktrace snapshot during getFormattedMessage() invocation, please > let me know, thank you > > reg, > Eugen > > -- > You received this message because you are subscribed to the Google Groups > "gwt-log" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/gwt-log?hl=en. > > -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 [email protected] -- You received this message because you are subscribed to the Google Groups "gwt-log" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/gwt-log?hl=en.
