I think it would be ok to have people modify in the name of progress
and consistency, personally.
On Sep 15, 9:34 am, "Mirko Nasato" <[EMAIL PROTECTED]> wrote:
> Yes I think other configuration parameters could be useful from the command
> line, like logLevel, noServer, port, etc.
>
> There isn't a strict naming standard, but for consistency we could just use
> the parameter name with a "gwt" prefix for all expressions, so gwt.style,
> gwt.logLevel, gwt.noServer, etc.
>
> Ideally we could also rename google.webtoolkit.home to gwt.gwtHome, but that
> would force people that to modify their pom files.
>
> 2008/9/15 Charlie Collins <[EMAIL PROTECTED]>
>
>
>
> > Hey, on that note, should we possibly add expressions for other stuff
> > too, and maybe even change some of the existing ones to be more
> > consistent?
>
> > Truth be told, I was a bit confused about "gwtHome" as a parameter in
> > the POM config, and yet "google.webtoolkit.home" as a "property" in
> > settings.xml or a profile. What you have just taught me explains that
> > perfectly of course, but maybe parameters like "gwtHome" should have
> > an expression "gwtHome" also? Or is there some kind of standard that
> > exists for what the names should be?
>
> > On Sep 14, 2:35 pm, Charlie Collins <[EMAIL PROTECTED]> wrote:
> > > Ah, that's how that connection is made, I get it now, thanks for
> > > clearing that up. I learn a little more about this mojo crap every
> > > day ;).
>
> > > On Sep 14, 1:07 pm, "Mirko Nasato" <[EMAIL PROTECTED]> wrote:
>
> > > > It's very easy: the @parameter javadoc annotation can specify an
> > > > 'expression' attribute. Then you can use that same expression from the
> > > > command line.
>
> > > > So I'd like to change in AbstractGWTMojo
>
> > > > /**
> > > > * GWT JavaScript compiler output style (-style OBF[USCATED],
> > PRETTY, or
> > > > * DETAILED).
> > > > *
> > > > * @parameter default-value="OBF"
> > > > */
> > > > private String style;
>
> > > > to
>
> > > > /**
> > > > * GWT JavaScript compiler output style (-style OBF[USCATED],
> > PRETTY, or
> > > > * DETAILED).
> > > > *
> > > > * @parameter expression="${gwt.output.style}" default-value="OBF"
> > > > */
> > > > private String style;
>
> > > > and possibly do the same with other parameters where it may make sense
> > to
> > > > pass them on the command line.
>
> > > > 2008/9/14 Charlie Collins <[EMAIL PROTECTED]>
>
> > > > > I think you can already do that, can't you specify any parameter on
> > > > > the command line? I am not sure how that works, but I use stuff like
> > -
> > > > > Dmaven.test.skip and so on all the time. Are those special handing
> > > > > system props that the test plugin supports, or is that just the right
> > > > > param and Maven picks it up from POM or command line automatically?
>
> > > > > On Sep 12, 11:02 am, "Mirko Nasato" <[EMAIL PROTECTED]> wrote:
> > > > > > Hi Charlie et alters,
>
> > > > > > I'd like to add some more command line expressions for the existing
> > > > > > configuration options.
>
> > > > > > For example, the GWT output style can be configured in the pom.xml.
> > > > > However
> > > > > > I typically want to leave it to default of OBF (for production),
> > and only
> > > > > > want to specify a different style when I encounter a JavaScript
> > issue
> > > > > that I
> > > > > > need to debug. In that case it's easier to just pass the option on
> > the
> > > > > > command line
>
> > > > > > mvn -Dgwt.output.style=DETAILED gwt:compile
>
> > > > > > If there are no objections I'll create an issue in the tracker and
> > then
> > > > > > implement it.
>
> > > > > > Thanks
>
> > > > > > Mirko
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"gwt-maven" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/gwt-maven?hl=en
-~----------~----~----~----~------~----~------~--~---
