Looks like some good work to me. I added you as a project member based on your email request.
KEEP IN MIND THOUGH - this project will be merged with the Mojo one as soon as I get some time. When that happens I will be basically closing this one down. I plan to get all the features into the Mojo one, and might recruit those that really contribute here to that, but this project will basically be deprecated at some point in the future. On Dec 28, 7:46 pm, Mark <[email protected]> wrote: > Hi, > At weekend i've worked on running GWT application that uses GWT-maven > as build mechanism, Ext GWT for rich client and GWT-SL for integration > with Spring. Some problems araised, so I've downloaded sources for gwt- > maven and made some changes that solved most of them. I think this > work would be helpful for gwt-maven, so I've uploaded modified > projects (not patches, sorry..) to this group. Up to date are: > > maven-googlewebtoolkit-support.tar.bz2 (2) > maven-googlewebtoolkit2-plugin.tar.bz2 (2) > > I've described main changes in CHANGES.txt file which is in "maven- > googlewebtoolkit2-plugin.tar.bz2 (2)" file. I would be happy if > someone from project developers would look at changes I've made and > gave me some feedback. What do you think about it? What's your opinion > what should be done another way? etc. > > CHANGES.txt: > > 1. Suspended debug configuration was not used for windows - plugin > always run debugging in suspended mode. > 2. Rewrite of ScriptWriters - redundant code was deleted. > AbstractScriptWriter created. > 3. Some javadocs form ScriptWriters. > 4. CompileMojo copies files from WEB-INF/ from resource direcotries to > target/tomcat/webapps/ROOT/WEB-INF/ (except of web.xml). > 5. CompileMojo copies files from ${output} directory to target/tomcat/ > webapps/ROOT/. I'm not sure is it always necessary, but when using gwt- > sl it is. > 6. In my opinion code listed below should always throw an exception. > It uses classloader from GwtWebInfProcessor class, which is plugin's > internal class. Classloader used in method getResource cannot see > nothing from project which is builded by the plugin. That's why there > is "fixThreadClasspath" method in AbstractGWTMojo - this classloader > is constructed with addition of resources from project. > > Code from GwtWebInfProcessor > (once in constructor, once in getServletDescriptors): > > if (GwtWebInfProcessor.class.getResource("/" + moduleName.replace('.', > '/') + ".gwt.xml") == null > ) { > throw new Exception("Unable to locate module definition file: " + > moduleName.replace('.', '/') + ".gwt.xml"); > > } --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "gwt-maven" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/gwt-maven?hl=en -~----------~----~----~----~------~----~------~--~---
