Hi,
> Statement for contributions (not significant, in my opinion
Sure. This was not my idea... It was requested by Eclipse (but
unrelated to EPL).
> Allocation routines aren't always optimal
I know - that's one of the reasons I am working on the 'page store' mechanism.
> getAddress
I think this method gets inlined by the JVM, so manually inlining will
not help. But I may be wrong.
> Improved performance on DiskFile.initFromSummary / getSummary -- in one test,
> this is 4x faster
Could you submit this test? I'm not sure how your changes could help,
unless getAddress is not inlined.
> setRange(final int start, final int len, final boolean value) {
I don't want to use 'final' for parameters and local variables because
I think it clutters the code. Unless it is faster of course.
- private long getBitMask(int i) {
+ private static long getBitMask(int i) {
Does this improve performance? If not I like to keep the old code.
> setRange
Do you have some statistics that show how many time it is called with
which len? I like to avoid optimizing this method if it doesn't
improve performance. Do you have a micro-benchmark for your changes? I
like to compare how much the changes improved performance.
> Before patch : 23275 and 31407 statement/sec
> After patch: 23564 and 32854 statement/sec
That could be a random difference (noise).
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "H2
Database" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/h2-database?hl=en
-~----------~----~----~----~------~----~------~--~---
