Hi,
> Please let me know, if this feature (schema specific functionaliases) is
> worth finding it's way into the main source.
Yes, I think that would be a nice feature. Could you explain why
exactly you need it? If is a compatibility problem, if yes:
compatibility with which database?
A few remarks about the patch:
SchemaCommand: the following line does not follow the code style of
the rest of H2:
if (schema == null ) throw new NullPointerException("Schema is null.");
(it should be an internal error, not a null pointer; use { })
Database.java: don't comment out code. Instead, remove the code.
FunctionAlias.java: why did you remove the "if (!force) {" ? Don't.
FunctionAlias.java: "space deleted" - I don't understand that. Don't
remove the space.
The code formatting is incorrect in several files. See
http://www.h2database.com/html/build.html#providing_patches -
specially eclipseCodeStyle
Otherwise the patch looks very good. It's great that you have added test cases!
Regards,
Thomas
--
You received this message because you are subscribed to the Google Groups "H2
Database" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/h2-database?hl=en.
