I agree. But my english was also not very clear :) What I meant to say was that after profiling, I attached the debugger and noticed that the compareRows() method is called a lot of times with the same row. These rows are now also compared, but that is not necessary. you might not gain much here, but its a waste to do, if it's already clear they are equal.
I'll take a look at the tests and see if there is any noticeable difference. - Ronald On Mar 16, 12:29 pm, Noel Grandin <[email protected]> wrote: > With the degree of inlining and run-time optimisation that the Hotspot > VM does, it's hard to be sure about the stuff you see in a profiler > without actual A/B testing. > You could try building the code and do some before/after tests > There are performance unit-tests in the test folder you could use. > > On 2012-03-16 12:47, rkrijgsheld wrote: > > > > > > > > > Hi All, > > > Just a small observation. I was profiling my application and found the > > following: BaseIndex.compareRows(rowData, compare) is called a lot of > > times, but also a lot of times where rowData and compare are the same > > row. I suspect an equals check should be enough in that case. I don't > > know if it will give much improvement, but I see that in > > MVCC.removeIfExsists() is called a lot of times, which indirectly used > > the compareRows. > > > - Ronald -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/h2-database?hl=en.
