Sounds good Noel. I'd mocked up a similar patch, which I hadn't yet submitted. Instead of using a list of strings, I stored the params as a Properties object called "storageParams" attached to the CreateTableData object. In the case where the string is just on its own (no equal sign), I'd set the right hand side to "true". I think this would simplify consumption by most TableEngine implementors as they will want to interrogate these values as properties?
On Monday, June 24, 2013 4:08:39 AM UTC-4, Noel Grandin wrote: > > I have just added support (revision 4861) for passing additional > arguments into custom TableEngine implementations. > > You can try it out in tonight's nightly build. > > The syntax looks like > CREATE TABLE t1(id int, name varchar) ENGINE com.acme.MyEngine WITH > "param1", "param2" > > And the parameters are available as a list of strings in the > tableEngineParams field of CreateTableData > > Regards, Noel Grandin > > On 2013-05-30 17:12, Andrew Franklin wrote: > > The way I see it, the TableEngine interface has the potential to > > enable traditional SQL access to many NoSQL style stores, while > > removing the burden of implementing a JDBC driver (and SQL parser) and > > enabling the developer to concentrate on the much smaller task of the > > data to table adapter portion. > > > > In my specific use case, each table would have a different path; but > > there may be other optional config options that are specific to the > > engine that could be passed in. Examples might include map fill > > factors, debugging options? > > > > I'm wary of YAGNI too; so if there is an alternative to my suggestion > > then I'm happy to look into it instead. > > -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/groups/opt_out.
