Hi, Hm, it's interesting, but I'm not quite sure if the change is worth it. What are the pain points?
> ability to clean up resources when a trigger is dropped (not just when the database is closed) There are already method Trigger.remove() and Trigger.close(). Your interface only has close(). So it's actually one step back from what we have now? > Simplified init() method Well, in a way you added complexity by adding a class. But I see your point, having 6 parameters isn't all that great. But this change alone isn't worth the trouble I think. Changing the API needs to have a real, big benefit. > Performance benefit for triggers that process multiple rows Sorry what is the performance benefit? Also, do you have a benchmark? > Ability to detect when triggers are fired by SELECT or ROLLBACK Well, what would you pass when rolling back an update in the fire method: UPDATE or ROLLBACK? In fact both should be passed... Regards, Thomas On Wed, Jul 17, 2013 at 2:25 AM, Gili <[email protected]<javascript:_e({}, 'cvml', '[email protected]');> > wrote: > Hi, > > I'd like to propose a new Trigger interface (attached) with the following > benefits: > > - > - Simplified init() method: Users can pull as little or as much data > as they'd like from class Metadata. > - Performance benefit for triggers that process multiple rows: > PreparedStatements > sharing using initTransaction(), closeTransaction(). > - Ability to detect when triggers are fired by SELECT or ROLLBACK. > - Ability to clean up resources when a trigger is dropped (not just > when the database is closed). > > I initially shared this proposal with Noel a few months back and had hoped > to implement it myself. Unfortunately, my work schedule has gotten > completely out of hand and I no longer believe that I will be able to work > on it after all. I am sharing it with the community in the hopes that you > will pick up where I left off. > > Kind regards, > Gili > > -- > You received this message because you are subscribed to the Google Groups > "H2 Database" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:_e({}, > 'cvml', 'h2-database%[email protected]');>. > To post to this group, send email to > [email protected]<javascript:_e({}, 'cvml', > '[email protected]');> > . > Visit this group at http://groups.google.com/group/h2-database. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/groups/opt_out.
