Ok, so here you are the revised patch.txt <http://h2-database.66688.n3.nabble.com/file/n4027076/patch.txt> . I've added some dedicated tests... they seem to pass, but if I connect using h2 console and set JAVA_OBJECT_SERIALIZER from JDBC url I don't see it on /INFORMATION_SCHEMA.SETTINGS/ (supposing it should be reflected there).
Noel Grandin wrote > Hi > > On 2013-08-07 12:52, davide.cavestro wrote: >> 1. Could you please give me a hint on where the parameter /CACHE_SIZE/ is >> loaded from the JDBC URL? I still don't understand why >> /JAVA_OBJECT_SERIALIZER/ gets discarded from JDBC url derived settings >> while >> /CACHE_SIZE/ works properly . The setting is simply declared as available >> into /SetTypes.java/ and processed into /Set.java/... I've removed >> /javaObjectSerializer/ from /DBSettings/ in order to see if it makes >> difference, but it seems not enough. > > CACHE_SIZE is stored inside the DB file itself as part of the DB > metadata, so it will get loaded from the DB itself at startup time, > if it has been defined via a > SET CACHE_SIZE > command. > Otherwise it will get loaded from the properties in ConnectionInfo which > are in turn derived from the properties stored on the database URL. > > But don't worry too much about this part, I'll tweak the patch if > necessary. > > >> 2. I've also added the same new error code message to >> //h2/src/main/org/h2/res/_messages_en.prop/ and >> //h2/src/docsrc/textbase/_messages_en.prop/ as they are both under >> version >> control... maybe one is derived from the other? > Yeah, that's correct. We should probably move one of them into a > build-temporary directory. > I think the first one is the right one to modify. > > > -- > You received this message because you are subscribed to the Google Groups > "H2 Database" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to > h2-database+unsubscribe@ > . > To post to this group, send email to > h2-database@ > . > Visit this group at http://groups.google.com/group/h2-database. > For more options, visit https://groups.google.com/groups/opt_out. -- View this message in context: http://h2-database.66688.n3.nabble.com/Database-level-custom-serialization-for-columns-of-type-OTHER-patch-proposal-tp4026990p4027076.html Sent from the H2 Database mailing list archive at Nabble.com. -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/groups/opt_out.
