Hi,
I made a few changes:
- Rename "getNoDimensions" to "getDimensionCount", because
"getNoDimensions" is confusing for non-native English speaking people ("get
no dimensions versus get yes dimensions" ?!)
- Rename the overloaded method "isGeometry" to "isGeometryClass" to avoid
confusion. I know method overloading, but it shouldn't be used if the
meaning of the method is different.
About com.vividsolutions.jts.geom.Geometry#equals, I'm sure we find a
solution. I agree with Noel, that if the objects are not equal then the JTS
suite shouldn't return true. But if it's not possible to fix the JTS suite
within a reasonable time, then we might want to add a workaround. But
document it as such.
Regards,
Thomas
On Mon, Aug 19, 2013 at 3:47 PM, Noel Grandin <[email protected]> wrote:
> No, that's a bug in the com.vividsolutions.jts.geom.**Geometry#equals
> method, which the JTS guys will need to fix.
>
> Let us know when they have a fixed build available.
>
>
> On 2013-08-19 14:46, Nicolas Fortin (OrbisGIS) wrote:
>
>> I wrote a unit test:
>> https://github.com/nicolas-f/**h2database/commit/**
>> ea22bd7532150a17a1e92b009a98bf**389a7f3f7f#L1R533<https://github.com/nicolas-f/h2database/commit/ea22bd7532150a17a1e92b009a98bf389a7f3f7f#L1R533>
>>
>> If you take two geometries A "POLYGON ((67 13, 67 18, 59 18, 59 13, 67
>> 13)) and B "POLYGON ((67 13 , 67 18 5, 59 18, 59 13, 67 13 ))"
>>
>> The result of A.equal(B) is true.. Then the cache system of Value will
>> keep only A and garbage B. The only way to fix this issue is to do a binary
>> comparison in ValueGeometry.equals( )
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "H2 Database" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
> h2-database+unsubscribe@**googlegroups.com<h2-database%[email protected]>
> .
> To post to this group, send email to [email protected].
> Visit this group at
> http://groups.google.com/**group/h2-database<http://groups.google.com/group/h2-database>
> .
> For more options, visit
> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
> .
>
--
You received this message because you are subscribed to the Google Groups "H2
Database" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/h2-database.
For more options, visit https://groups.google.com/groups/opt_out.
