Hi,
MVStore.getRetainVersion is used internally by
MVMap.removeUnusedOldVersions. Maybe the method should be renamed, and a
new method getRetainVersion should be added that returns the value you
passed in the setter.
And you are right the "if" statement is strange:
if (currentStoreVersion >= -1) {
currentStoreVersion is never smaller than -1 as far as I see, so the "if"
could be removed (if it is even correct).
So this will need to be fixed.
Regards,
Thomas
On Wed, Sep 11, 2013 at 11:36 PM, John Leacox <[email protected]> wrote:
> On an MVStore that has been in use for a while and has multiple versions
> stored calling MVStore#getRetainVersion() always returns -1 even after
> MVStore#setRetainVersion() is called.
>
> The following code will print -1:
> store.setRetainVersion(store.getCommitedVersion();
> System.out.println(store.getRetainVersion());
>
> I was looking at the implementation of MVStore#getRetainVersion and I
> noticed that it checks that currentStoreVersion is greater than -1. Is
> this the correct variable for this check or should it be checking
> currentVersion instead?
>
> --
> You received this message because you are subscribed to the Google Groups
> "H2 Database" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> Visit this group at http://groups.google.com/group/h2-database.
> For more options, visit https://groups.google.com/groups/opt_out.
>
--
You received this message because you are subscribed to the Google Groups "H2
Database" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/h2-database.
For more options, visit https://groups.google.com/groups/opt_out.
