If this patch is accepted - what are the odds for getting it backported to 1.3? :)
//Anders On Monday, April 28, 2014 8:26:42 AM UTC+2, Anders Engström wrote: > > Hi again! > > Sorry for the delay. I've created a new patch where I'm using the > loadUserClass instead. > > Please have a look at it :) > > Best regards //Anders > > On Friday, April 25, 2014 3:56:42 PM UTC+2, Anders Engström wrote: >> >> Howdy! >> >> On Friday, April 25, 2014 3:38:27 PM UTC+2, Thomas Mueller wrote: >> >> >>> > Are you referring to using `Utils.loadUserClass` to check if the class >>> > is available or not (before trying to create the >>> `OsgiDataSourceFactory` >>> > and register it as a service)? >>> >>> Yes. >>> >>> >> I'll adjust the patch accordingly :) I'll ping back here when I've >> attached a new patch to the issue :) >> >> //Anders >> >> >>> On Fri, Apr 25, 2014 at 12:01 PM, Anders Engström <[email protected]>wrote: >>> >>>> >>>> Hi again! >>>> >>>> >>>> On 04/24/2014 09:09 PM, Thomas Mueller wrote: >>>> >>>>> I didn't find any standard logging strategy in the h2 code base >>>>>> >>>>> >>>>> Well, at this level there is none (I don't want to hardcode SLF4J or >>>>> use java.utils.logging). Maybe the best option is not to log. >>>>> >>>> >>>> Sure - I can remove the System.err call from the patch. One alternative >>>> would be to use org.osgi.service.log.LogService (if *that one* is >>>> available) - but it feels like an over-engineered solution at this >>>> point. >>>> >>>> >>>> But is it possible to use Class.forName instead, similar to how it's >>>>> done in org.h2.value.DataType.GEOMETRY_CLASS_NAME / GEOMETRY_CLASS, >>>>> with Class.forName()? >>>>> >>>>> >>>> Are you referring to using `Utils.loadUserClass` to check if the class >>>> is available or not (before trying to create the `OsgiDataSourceFactory` >>>> and register it as a service)? >>>> >>>> [snip] >>>> >>>> >>>> Best regards //Anders >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "H2 Database" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at http://groups.google.com/group/h2-database. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/d/optout.
