Hello,
Sorry for resurrecting the thread when the conversation seem to have
concluded.
As in the original posting, I see a similar synchronization bottleneck in
DateTimeUtils.dateValueFromDate method on a global calendar instance:
public static long dateValueFromDate(long ms) {
Calendar cal = getCalendar();
synchronized (cal) {
cal.clear();
cal.setTimeInMillis(ms);
return dateValueFromCalendar(cal);
}
}
Unfortunately I'm hitting this not in a synthetic benchmark, but in a
real-world scenario (our application loads a lot dates on startup, and
we're using multithread'ed mode to parallelise the load).
I was wondering what if there was a fix for getTimeTry synchronization ( a
threadLocal was suggested which seem to fit well in the case)?
(I've checked the code
here<http://code.google.com/p/h2database/source/browse/trunk/h2/src/main/org/h2/util/DateTimeUtils.java>does
not seem to be updated).
Would be great to apply the same fix for dateValueFromDate.
Thanks a lot,
ilya
On Thursday, May 8, 2014 12:48:03 PM UTC+1, Noel Grandin wrote:
>
>
>
> On 2014-05-08 12:22, Lukas Eder wrote:
> > Great, thank you very much Noel. I will get back to this once I will be
> able to upgrade. I assume that the fix is
> > available from the latest automated build available here:
> > http://www.h2database.com/html/download.html
> >
> Should be by tomorrow morning (the build runs overnight).
>
>
--
You received this message because you are subscribed to the Google Groups "H2
Database" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/h2-database.
For more options, visit https://groups.google.com/d/optout.
