Hi Abhishek, I've had a look at the webrev you provided and have the following comments.
It appears that the agent has been built using the DS builder which performs several tasks associated with the delivery of an agent, i.e. packaging, wrapper scripts to register the agent as well as bring it online and offline etc. While this is fine the only issue is how you would like to proceed going forward. In this regard, you have two options. - You can simply request that the agent is placed within the 3rd Party Agent repository, i.e. http://opensolaris.org/os/community/ha-clusters/ohac/3rd-party-agents/ . However, doing this will mean that the agent remains in that repository and subsequently is not packaged with subsequent Open HA Cluster deliveries on OpenSolaris. - As you submitted a project proposal that was approved by the core contributors, you could follow through and request that the agent is packaged with Open HA Cluster. In oder to do this, you will need to reformat your agent from the format that it currently is in and into a format that would represent the gate structure. For an example of this you could take a look at any of the Cluster Agent: *** listed within the Endorsed Projects at http://opensolaris.org/os/community/ha-clusters/ Additionally, you could take a look at the gate structure, for example the HA-Informix agent can be viewed at http://src.opensolaris.org/source/xref/ohac/ohacds/usr/src/cmd/ha-services/gds-agents/ids/ If you decide to follow this route then you would need to create a source repository, where you can then add your reformatted code, i.e. please review http://www.opensolaris.org/os/community/ha-clusters/ohac/contribute/OHACDevProcess/ In terms of creating your own leaf node within that source repository, you could simply copy the files within the HA-Informix agent into your leaf node and rename any appropriate files or leverage the coding of the GDS template, i.e. http://www.opensolaris.org/os/community/ha-clusters/ohac/GDS-template/ Alternatively, you can take a different coding patch and leverage either a DSDL approach using C or SCHA using ksh, examples of both can be found within http://src.opensolaris.org/source/xref/ohac/ohacds/usr/src/cmd/ha-services/ Anyway, with all that out of the way, you should be congratulated for your contribution. So however you decide to proceed I am sure that the HA-JBOSS agent will be of help to many others. Many thanks. Regards Neil On 4 Feb 2009, at 09:17, Kumar Abhishek wrote: > Hi, > > I have done some coding on HA-JBoss and have done some initial > testing. > I would request you to kindly review the code which you can find at > http://cr.opensolaris.org/~krabhi/ha-jboss/ > > You can find the design document for this project at > http://opensolaris.org/os/project/ha-jboss/files/HA-JBoss_Design_Doc.pdf > > Summary > ========= > > The script startjboss in /util folder attempts to register a resource > group for ha-jboss by executing the run.sh file in JBOSS_HOME/bin > directory. > It passes a custom configuration directory path and custom > configuration > name as a parameter to the start script. The values of these variables > are provided in the jboss_config file inside the same directory. > > Before registering the resource group, the script tries to validate > the > parameters provided by checking is the path provided in the > jboss_config > file are valid and have appropriate permissions. > > The probe command probes the JBoss server by using wget and it also > probes all the custom URLs which are included in a text file, path of > which is set in PROBE_URL_LIST variable in jboss_config file. > ========= > > > Please suggest me the changes I should incorporate in what I have done > so far. > > Thank you for your time. > > Regards, > Abhishek > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
