Hi Swathi et al,

I made a mistake when I did copy my master StarCalc file to the version 
I published - changed the suffix to odb by mistake - renaming it to .ods 
should have fixed it.

I did update the file once more to clarify the SUNWapch22 dependency and 
the correct full path to apachectl:

http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090220.ods
http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090220.csv.txt

Since both, apache and dns have the upstream community version within 
the full package string, I propose a compromise - we depend just on the 
package name, but not on a specific version. This will then 
automatically always pull in the most current one for this package.

The updated webrev does reflect that:
http://cr.opensolaris.org/~frueauf/colorado-1-ips-agent-dependencies-3/

If there are no further commenst/objections, I would plan to do the 
putback by the end of my working day (MET timezone).

Greets
       Thorsten

Swathi Devulapalli wrote:
> Hi Thorsten,
> 
> Please see inline.
> 
> On 02/19/09 21:00, Thorsten Frueauf wrote:
>> Hi Swathi et al,
>>
>> thanks a lot for your comments, see some comments/questions inline:
>>
>> Swathi Devulapalli wrote:
>>> Hi Thorsten,
>>>
>>> Thanks for working on these agents. Please see my comments below. I 
>>> have reviewed Apache, DNS and S1AS.
>>>
>>> 1. SUNWscs1as package also contains jsas and jsas-na. You will need 
>>> to include jsas.c, jsas_utils.sh, jsas.h. jsas-na.c jsas-na_utils.sh, 
>>> jsas-na.h.
>>
>> Ah, thanks for pointing that out! I was not aware that the jsas and 
>> jsas-na directory also belong to this agent package. And there is even 
>> one more additional script: jsas-na/jsas-get-na-list.sh
>>
>>> I have gone through these files. You may want to add a "*" against 
>>> /usr/bin/echo and /usr/bin/grep for SUNWscs1as.
>>
>> I did update the StarCalc and csv sheet with your and my additional 
>> findings:
>> http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090219.odp
>>  
>>
>> http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090219.csv.txt
>>  
>>
>>
>> This does result into two new added dependencies:
>> +depend fmri=SUNWesu at 0.5.11-%SOLBRANCHVER% type=require
>> +depend fmri=sunwscc...@%compver%-%branchver% type=require
>>
>> I did not add the SUNWcs dependency here, since that one got already 
>> captured within depend_auto.
>>
>> webrev got updated:
>> http://cr.opensolaris.org/~frueauf/colorado-1-ips-agent-dependencies-2/
> [Swathi] Thanks for making this change. I am not able to view the .odp 
> file. Was it not .ods file?
>>
>>> 2. SUNWscapc: In nevada, the apache2 directory layout has been 
>>> modified. It's something like /usr/apache2/2.1/bin/apachectl,  
>>> /usr/apache2/2.2/bin/apachectl, etc. Although we made changes in 
>>> dsconfig to meet this requirement, we still have this code for 
>>> Solaris10.
>>> I recommend not to have any dependency with Apache2 version as the 
>>> directory layout has undergone some rounds of rework. Having
>>> the default apache(1.*) version should be fine, which is 
>>> /usr/apache/bin/.
>>
>> Hm, does that mean the agent does not work with apache2 on Nevada (= 
>> Solaris Express)?
>>
>> I guess the same then applies to OpenSolaris (the binary distribution) 
>> - ie. the agent does not work for apache2?
> [Swathi} Ok. I think I was misleading. The agent does work for Solaris 
> 11 and apache2. We seek the inputs from user for the apache binary
> location. So, there is no problem with the code. Whereas in the apache 
> wizards, we do an auto discovery, which we had to fix for Nevada.
> However, my comment was for the "opensolaris command" you mentioned in 
> the .ods file. The opensolaris command
> "/usr/apache2/bin/apachectl" has changed although the package SUNWapch2 
> might be the same.
>>
>> I can see multiple apache2 packages in the repo, where 
>> SUNWapch22 at 2.2.9-0.101 seems to be the current one for OpenSolaris 
>> 2008.11.
>>
>> Your recommendation is then to only enable the following dependency:
>>
>> depend fmri=SUNWapch at 1.3.41-%SOLBRANCHVER% type=require
>>
>> and none for the SUNWapach22?
> [Swathi] I said there should be no dependency with SUNWapch2 package 
> because there are multiple versions of Apache2 available. As you are 
> saying SUNWapch22 is the one for OpenSolaris 2008.11, I would suggest to 
> just pull Apache22 as we do support Apache2 in the agents.Sorry for the 
> confusion!
>>
>> How about the SUNWscdns agent. Would you recommend for or against 
>> including the dependency
>>
>> depend fmri=SUNWbind at 9.3.5.2-%SOLBRANCHVER% type=require
>>
>> ?
> [Swathi] I can not comment on the versions of DNS as I am not much aware 
> of it. But I would recommend for going ahead with the dependency.
> 
> Thanks,
> Swathi
>>
>> Greets
>>       Thorsten
>>
>>> Thanks,
>>> Swathi
>>>
>>> On 02/17/09 02:00, Thorsten Frueauf wrote:
>>>> Hi everyone,
>>>>
>>>> the following is about my current work to manually determine package
>>>> dependencies for the 11 agents, which are part of Colorado-I.
>>>>
>>>> I already got some positive feedback by Detlef Ulherr for 
>>>> SUNWscPostgreSQL, SUNWsctomcat and SUNWscmys, and from Neil 
>>>> Garhtwaite for SUNWscdhc and SUNWscsmb - thanks a lot!
>>>>
>>>> I specifically seek review for
>>>>
>>>> SUNWscapc (HA Apache)
>>>> SUNWscdns (HA DNS)
>>>> SUNWsckrb5 (HA Kerberos)
>>>> SUNWscnfs (HA NFS)
>>>> SUNWscs1as (HA SunOne Appserver / Glassfish)
>>>>
>>>> since I am not the agent expert for them, I would appreciate if
>>>> the owners could have a look to verify and sanity check with the
>>>> dependencies I found and determined.
>>>>
>>>> Here is what I did:
>>>>
>>>> Step 1) Going through all source files of the individual agents, I did
>>>>         record the commands getting invoked by the code, the
>>>>         corresponding packages for those commands, and which agent did
>>>>         really use them, marked with a "*" in the correspinding row.
>>>>         I did also record which files I did analyze.
>>>>         The result is in a StarCalc sheet, available at
>>>>
>>>> http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090210.ods
>>>>  
>>>>
>>>>
>>>> Step 2) The StarCalc sheet can get saved as .csv file, where the
>>>>         separator is "," and content of fields is kept in double 
>>>> quotes.
>>>>         The result is available at
>>>>
>>>> http://opensolaris.org/os/project/colorado/files/Colorado-I-IPS-agent-dependencies-20090210.cvs.txt
>>>>  
>>>>
>>>>
>>>> Step 3) Have a script which uses awk to extract the package list by
>>>>         looking at the "*" recorded for each package.
>>>>         This then results into a sorted list of uniq packages.
>>>>         The script I used is available at
>>>>
>>>> http://opensolaris.org/os/project/colorado/files/map-agent-package-dependency.ksh.txt
>>>>  
>>>>
>>>>
>>>> Step 4) Verify the list shown by the script of Step 3) and insert the
>>>>         missing entries into the 
>>>> usr/src/ipsdefs/<package>/depend_static
>>>>         file. I did leave out entries already recorded within 
>>>> depend_auto.
>>>>
>>>> The result can be reviewd within the following webrev:
>>>> http://cr.opensolaris.org/~frueauf/colorado-1-ips-agent-dependencies/
>>>>
>>>> Please note the following:
>>>>
>>>> - I did bump the year to 2009 within the common copyright file. 
>>>> Guess the
>>>>   same needs to be done within the core gate (was only recently done 
>>>> within
>>>>   the pkgdefs area, but not within ipsdefs). Is it ok to have it 
>>>> part of this
>>>>   review/putback? I am also happy to leave it out, if required.
>>>>
>>>> - I did add the dependency to the group package 
>>>> ha-cluster-framework-minimal
>>>>   to all packages. That way if the user just installs the agent 
>>>> package,
>>>>   it should pull in all required packages in order to configure a 
>>>> working
>>>>   cluster.
>>>>
>>>> - The following files contain questions, where I seek input, before I
>>>>   finalize and send out the webrev to ha-clusters-discuss:
>>>>
>>>>   * SUNWscapc/depend_static
>>>>   * SUNWscdns/depend_static
>>>>   * SUNWsckrb5/depend_static
>>>>   * SUNWscnfs/depend_static
>>>>   * SUNWscs1as/depend_static
>>>>
>>>>   a) for some I am not sure to record the OpenSolaris package
>>>>      dependency for the application - specifically I don't know if it
>>>>      is a good idea to depend on just one version.
>>>>      I would be fine with nfs and krb5, but I doubt if we want that for
>>>>      dns and apache - although we have hardcoded paths. At least in the
>>>>      case of apache we offer choice, and maybe users do not want both
>>>>      versions.
>>>>
>>>>   b) for the non-GDS based agents my auto conversion recorded the 
>>>> dependencies
>>>>      from the pkgdefs common depend file. I would tend to delete 
>>>> those entries,
>>>>      but would like to get feedback how reasonable they are.
>>>>
>>>> Greets
>>>>       Thorsten
>>>>
>>>>
>>

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Sitz der Gesellschaft:
   Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
   Amtsgericht Muenchen: HRB 161028
   Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
   Vorsitzender des Aufsichtsrates: Martin Haering
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reply via email to