Jonathan,

Thanks for the review. See below.

Jonathan Mellors wrote:
> Hi Nick,
> 
> Aside from Thorsten's comments:
> 
> usr/src/tools/scripts/depotctl.ksh:
>  - line 49 and line 100, comment says "(hashed to be between 1023 and 
> 65536)". It should actually say "(hashed to be between 1024 and 65535)".
> 
>  - line 217, again it should be "port between 1024 and 65535".

Fixed all instances.

> 
> usr/src/tools/scripts/Makefile:
>   - copyright 2009
>   - The lists were in alphabetical order, so it would be good to 
> continue that.
> 

Fixed.

Thanks,
Nick

> Thanks
> Jonathan
> 
> Nicholas Solter wrote:
>> Hi folks,
>>
>> Here's the depotctl script I've been promising for a while. It can be 
>> used to manage an IPS repository, employing the same port-based-on-UID 
>> scheme that Jonathan implemented for sending packages as part of the 
>> build. Generally you would run this script first to set up your 
>> repository, then run a build to send packages to the repository.
>>
>> http://cr.opensolaris.org/~nsolter/depotctl/webrev/
>>
>> Thanks,
>> Nick
>> _______________________________________________
>> ha-clusters-discuss mailing list
>> ha-clusters-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss


Reply via email to