Hi Neil, one comment on control_ebs.ksh:
*237 # We need to keep validate here for backward **238 # compatability as some components will be * * 239 # registered without the VALIDATE method.* I disagree wit this comment, The validation at the start will detect misconfigurations on the application. So in this case you will get a a pingpong regardless whether or not the validation is there, but the validation will throw messages which are important to diagnose the root cause. Without the validation before start, the administrator will be lost without information. ebs/functions.ksh 237 # SCMSGS 238 # @explanation 239 # The value specified for CON_LIMIT is invalid. 240 # @user_action 241 # Either accept the default value of CON_LIMIT=50 or change the 242 # value of CON_LIMIT to be less than or equal to 100 when 243 # registering the resource. Here you are not telling in the explanation that you will use the default value of 50, you should add that, according to the message isn scds_syslog. Great job. Detlef Neil Garthwaite wrote: > Hi Everyone, > > I would welcome a code review to address the following Bug IDs for the > existing Open HA Cluster agent for Oracle E-Business Suite. > > My webrev is located > at http://cr.opensolaris.org/~neilg/ohacds_ebs_webrev1 > <http://cr.opensolaris.org/%7Eneilg/ohacds_ebs_webrev1> > > Please let me know if you would like me to expand on the areas of the > code that are being touched to address each Bug ID below. > > *Synopsis:* SC 3.2 Oracle E-Business Suite agent should implement teh > Validate method <http://bugs.opensolaris.org/view_bug.do?bug_id=6732555> > *Bug ID:* 6732555 | *Category: *suncluster:ha-oracle_ebs > | *State:* 3-Accepted | *Keywords:* | *Reported:* 01-AUG-2008 > | *Reported against:* > *Last Updated:* 01-AUG-2008 > ------------------------------------------------------------------------ > *Synopsis:* SC 3.2 Oracle E-Business Suite agent should lower the > default CON_LIMIT <http://bugs.opensolaris.org/view_bug.do?bug_id=6732561> > *Bug ID:* 6732561 | *Category: *suncluster:ha-oracle_ebs > | *State:* 3-Accepted | *Keywords:* | *Reported:* 01-AUG-2008 > | *Reported against:* > *Last Updated:* 01-AUG-2008 > ------------------------------------------------------------------------ > *Synopsis:* EBS Implementation uses HA-Oracle Agent for the CMG > Listener which requires workarounds > <http://bugs.opensolaris.org/view_bug.do?bug_id=6623563> > *Bug ID:* 6623563 | *Category: *suncluster:ha-oracle_ebs > | *State:* 3-Accepted | *Keywords:* | *Reported:* 30-OCT-2007 > | *Reported against:* > *Last Updated:* 30-JUL-2008 > ------------------------------------------------------------------------ > *Synopsis:* CMG Register script does not properly set resource > dependency and scope > <http://bugs.opensolaris.org/view_bug.do?bug_id=6623572> > *Bug ID:* 6623572 | *Category: *suncluster:ha-oracle_ebs > | *State:* 3-Accepted | *Keywords:* | *Reported:* 30-OCT-2007 > | *Reported against:* > *Last Updated:* 30-JUL-2008 > ------------------------------------------------------------------------ > *Synopsis:* SC 3.2 agent for Oracle E-Business Suite support for > multiple instances with the same userid > <http://bugs.opensolaris.org/view_bug.do?bug_id=6727735> > *Bug ID:* 6727735 | *Category: *suncluster:ha-oracle_ebs > | *State:* 3-Accepted | *Keywords:* | *Reported:* 21-JUL-2008 > | *Reported against:* > *Last Updated:* 21-JUL-2008 > > Note that I am in the process of setting up a project page for this > work and have submitted a project proposal. If that project gets > approved, then I'll link this webrev to that project page. > > Regards > Neil > > > > ------------------------------------------------------------------------ > > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss > -- ***************************************************************************** Detlef Ulherr Staff Engineer Tel: (++49 6103) 752-248 Availability Engineering Fax: (++49 6103) 752-167 Sun Microsystems GmbH Amperestra?e 6 mailto:detlef.ulherr at sun.com 63225 Langen http://www.sun.de/ ***************************************************************************** Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering *****************************************************************************
