Hi Detlef,

* I suggest to also evaluate the Seconds_Behind_Master value in 
check_mysql_slave
  and mark the resource as DEGRADED if the replication lag is larger than a 
configurable
  value

* Parsing the status information can be simplified (and probably be implemented 
more
  robust regarding changes in the table format) by using ego (\G) to display 
results vertically
  (show slave status\G) and parse the name/value pairs, e.g. in a while read 
loop

* I believe check_mysql_slave() won't work if multiple masters are being 
defined on the
  slave (outside the cluster) - at least this limitation should be documented 
if it's by design.

* A general point which is not specific to your changes: Many OHAC (ex sun 
cluster) shell
  scripts' robustness would probably benefit from making more use of local 
variables.

* If I am not mistaking, the Mysql agent doesn't work with bind addresses (bind 
to
  (exactly one) specific address rather than IN_ADDR_ANY. I have once developed
  a workaround for this, but maybe someone wants to fix it? (I could help out 
if needed)
  (this is not related to Detlef's changes either)

Nils
--

This message posted from opensolaris.org


Reply via email to