Yue Lai wrote:
> Hi,
> 
> Please review the changes of introducing the incorporation package for 
> Colorado. The purpose of this package is to introduce conostraints so the 
> cluster packages can only be installed on specific OpenSolaris release. The 
> review is at:
> 
> http://cr.opensolaris.org/~llai/ha-cluster-incorporation/
> 

Lucia,

Thanks for all your hard work investigating the incorporation stuff.

usr/src/ipsdefs/ha-cluster-incorporation/depend_com

Is it ok to depend on ha-cluster-minimal while ha-cluster-minimal 
depends on it?

We should probably have a comment explaining the dependency on the 
entire package.

usr/src/ipsdefs/ha-cluster-incorporation/manifest_meta.tmpl

"incorporation" is misspelled in the pkg.summary and description values.

Other than that, it looks great!

Thanks,
Nick


Reply via email to