Hi Hemachandran et al,
here are my comments:
* usr/src/tools/ctf/cvt/Makefile.com
- line 22, need to change year to 2008
* usr/src/tools/ctf/cvt/ctf.c
- line 23, need to change year to 2008
* usr/src/tools/ctf/cvt/fixup_tdescs.c
- line 22, need to change year to 2008
- line 26, ensure ident string is not expanded when checked out
* usr/src/tools/ctf/cvt/st_parse.c
- line 750/751, strange formating change. Why the ; in a newline?
* usr/src/tools/ctf/cvt/typedef_bug.txt
- line 56ff., just to double check, the change from pxfs_v1 to pxfs
is correct? Since we used pxfs_v1 so far.
* usr/src/tools/ctf/cvt/util.c
- line 23, need to change year to 2008
For the record - I am not a CTF expert, so I can not comment on the
functional changes. I assume that you did build successfully and
verified that the binaries run.
From a debugging perspective, is mdb still able to resolve the
debugging info written into the ELF header for the binaries generated
with those changes?
Rest looks good to me!
Greets
Thorsten
Hemachandran Namachivayam wrote:
> Hi Folks,
>
> Here's the webrev for ctfconvert changes to support dwarf debug format
> for C++.
>
> List of changes for this webrev.
>
> o CTF tools support for C++ with DWARF representation. The changes
> include the fixes pulled from open-solaris gate.
>
> Thanks to Alexandre Chartre for the changes made to the CTF tools.
>
> o Remove the default format specification [i.e remove
> -xdebugformat=stabs]. Not required because of the above.
>
> o To address CR 6747192 "relocation error: R_AMD64_32: for Solaris
> cluster modules compiled from Ceres C++ 5.10 on OS 2008.05" change
> -Qoption ube -xmodel=kernel & -Wu,-xmodel=kernel
> to the full supported compiler option
> -xmodel=kernel
>
> The Webrev is at:
> http://cr.opensolaris.org/~hnamachi/ohac-ctf/
>
> -Thanks and Regards
> Hemachandran
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
