Hi Nick, Many thanks for the detailed review. Please see my comments below, I will update the docs to reflect your comments/requests.
Regards Neil Nicholas Solter wrote: >Neil, > >Sorry for the late review. In general, it looks good. Here are a few >comments: > >Caller Sequence: > >In the diagrams, the one on the right is labeled as running in the NG >zone, but I think you're really referring here to a specific case of >running in the NG zone using failover zones. That could be better >labeled to make it clear that the figure on the left actually applies to >global zone and non-global zone as "logical node." > >Should make it clear that one single agent can be used in any of the >three modes you specify (global, non-global, failover zone). > > > Agreed, I will update the doc to make this clear. >I'm confused as to whether the "HA-Informix code" you mention on slide 2 >is part of the agent or part of Informix itself. I think what you're >saying is that a "control script" serves as an adapter between GDS/SMF >and Informix itself. Is that correct? [Note: I see this is explained in >the design document]. > > > Agreed, I will update the doc to make this clear. >In slide 3, what change do you need to make to the config file? Can this >be done without requiring manual edits of a file (by resource >properties, for example)? > > > No, the edits to the config file determine the runtime environment that the IDS resource will use. The ids_config file will contains these values which are then used by the ids_register script. Upon registration the values are then stored in the CCR or SMF repository as reuiqred. I will update the doc to make this clear. >In slide 4, does the validation validate the resource properties, or >values set in the config file? > > The validate method is called when the resource is created or started. This is already described in paragraph 2 from the notes on slide 4. >In slide 7, can you say more about how the probe will actually probe >informix? > > Agreed, I will update the doc to reflect this. >Design Doc: > >I think you should give more details on the probe, as that's one of the >more interesting aspects of an agent. > > Agreed, I will update the doc to reflect this. >I think you should specify exactly what variables will be specified in >the config file. > > Agreed, I will update the doc to reflect this. >What's the difference between the registration file in 8 and the OHAC >registration file in 10? > > There's a typo in 8, it should read registration script vs registration file. However the difference between 8 & 10 is that 10 is the Resource Type Registration file so that the IDS agent can be registered and upgraded vs the registration file that is used in 8 to register the IDS resource. >Thanks, >Nick > >Neil Garthwaite wrote: > > >>Hi Everyone, >> >>Just a gentle reminder to say that the HA-Informix project page >>http://opensolaris.org/os/project/ha-informix has two documents that outline >>the design and caller sequence between the various components that this agent >>will use. >> >>The docs were posted on 7th August 2007, I'd appreciate any comments you have >>by the 18th October 2007. I stated in the project proposal that my aim is to >>"deliver this agent back to Solaris Cluster as a fully supported Solaris >>Cluster agent." >> >>Your help with reviewing these docs is much appreciated and will be helpful >>in getting this project into Solaris Cluster. >> >>Regards >>Neil >>-- >> >>This message posted from opensolaris.org >> >>_______________________________________________ >>ha-clusters-discuss mailing list >>ha-clusters-discuss at opensolaris.org >>http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss >> >> > > >
