Hi Jonathan, The changes look good. A few generic comments:
- Since you changed ipsdefs/Makefile... Could you also update the "ToDo" list in the comments to remove the stuffs that we have done? I told Nick I will do it, but my next putback will probably take a while. I think Nick also has the notes on what have been done in some meeting minutes. - Should we also add building "ipsdefs" into usr/src/Makefile such that building from "usr/src" will get the IPS packages published as well? If this was planned separately then it is fine too. See below for other comments: Jonathan Mellors wrote: > Hi Folks, > > Here's a couple of webrevs for the importing of the external SVR4 > packages from Docs and Localization into the IPS repository during the > build. This functionality is only required until Docs and L10N can > build their own IPS packages directly. > > This would have been a relatively small change, if it wasn't for the > fact that I had to move the "install: all ipssend" rule from > ipsdefs/Makefile.targ into the individual package Makefiles, so that > docs and l10n could use a different install rule. > > > Core: > http://cr.opensolaris.org/~jmellors/core-ips-extpkgs/ There must be a good reason to move "install: all ipssend" from Makefile.targ to each individual Makefile.... Due to order of setting the variables/macros? Looks like "install: all ipssend" is added to the packages that we don't deliver to IPS as well, like SUNWscsal etc and the packages defined in IPSNONSHIP_SUBDIRS in ipsdefs/Makefile? Do we have IPS SUNWscte[x] already to use the target "ipssend"? ... Never mind. I saw these won't get build any way by the control in ipsdefs/Makefile.... I wonder if we should have a ha-cluster-framework-man for the man pages. Looks like it is only included in ha-cluster-framework-full, and the only way to get man page is through installing SUNWscman itself or ha-cluster-framework-full.... Do you think creating a group package for SUNWscman could be helpful? Or we don't create group packages for single package and in this case the user can just install SUNWscman? Should not ha-cluster-quorum-server-full include SUNWscqsman? > > Agents: > http://cr.opensolaris.org/~jmellors/ds-ips-extpkgs/ Same comment about the man page as for core gate. Thanks! - Lucia > > Thanks > Jonathan > _______________________________________________ > ha-clusters-discuss mailing list > ha-clusters-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/ha-clusters-discuss
